New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

early foundryup check #65

Merged

carletex merged 12 commits into main from forge-check-early

Jun 21, 2024

Collaborator

technophile-04 commented Jun 20, 2024 •

edited

Loading

Description:

Replaced solidity framework strings values with enum (discussed in Cli solidity framework option #58 (comment)) not sure if its the best but please feel free to suggest better
used forge to install foundry libraries

technophile-04 added 6 commits

June 20, 2024 13:59


          replace string values with enum

217d035


          add foundryYup validation

c9eada7


          remove validation from outromessage

744f404


          use forge to install foundry libraries

06bcc74


          add changeset

1b59530


          rename foundryYup => foundryUp

0ab5542

technophile-04 commented

View reviewed changes

src/utils/system-validation.ts Outdated Show resolved Hide resolved


          fix lint

8a7dfa9

rin-st reviewed

View reviewed changes

src/utils/render-outro-message.ts Show resolved Hide resolved

rin-st reviewed

View reviewed changes

src/tasks/create-first-git-commit.ts Outdated Show resolved Hide resolved

rin-st reviewed

View reviewed changes

src/main.ts Show resolved Hide resolved

rin-st reviewed

View reviewed changes

src/utils/consts.ts Show resolved Hide resolved

rin-st reviewed

View reviewed changes

src/utils/system-validation.ts Outdated Show resolved Hide resolved

Member

rin-st commented Jun 20, 2024

Thanks Shiv, great change!

technophile-04 requested review from carletex and rin-st

June 20, 2024 16:41

rin-st approved these changes

View reviewed changes

Member

rin-st left a comment

Lgtm! Just added small nitpicks.

technophile-04 added 5 commits

June 21, 2024 12:43


          remove unused isSolidityFramework func

18e331c


          replace string literal with value from enum object

4894c79


          Merge remote-tracking branch 'origin/main' into forge-check-early

8e52694


          NOTE => Attention + align spaces with intro comment

826ad68


          Merge branch 'main' into forge-check-early

ff778e1

carletex approved these changes

View reviewed changes

Member

carletex left a comment

Working great @technophile-04 !!

We can tackle #65 (comment) in another PR

carletex merged commit baef4f1 into main

1 check passed

carletex deleted the forge-check-early branch

June 21, 2024 15:57

rin-st mentioned this pull request

Rename extentions to solidity framework #67

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet