Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cli solidity framework option #58

Merged
merged 6 commits into from
Jun 20, 2024
Merged

Cli solidity framework option #58

merged 6 commits into from
Jun 20, 2024

Conversation

rin-st
Copy link
Member

@rin-st rin-st commented Jun 18, 2024

Moved from scaffold-eth#801

Copy of description

Description

Solidity framework option from CLI. It could be a discussion but I think in this case it's easier to discuss when you already see the code. Feel free to add suggestions 🙂

usage examples (dev):

yarn cli --solidity-framework hardhat
yarn cli --solidity-framework=foundry
yarn cli -f none

In case of several solidity framework flags, last will be taken

Other options I thought about.

  1. --hardhat, --foundry and --skip-solidity-framework. Looks bad. Need to check if two or more flags chosen and add additional ifs to fix/throw error
  2. --extensions flag. It's not clear how to add let's say none, and how to mix it with other extensions non-related to solidity frameworks

Not sure how it will work with nested extensions but I think it's not a problem to update recurring logic if needed.

Also in this pr I added error if both --install and --skip-install chosen

Thanks!

Copy link
Collaborator

@technophile-04 technophile-04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice !! Thanks @rin-st !! added a couple of nitpicks but looks great already!

yarn cli ../test-712 -e eip-712 -f hardhat -i

This is gonna make scaffolding project while manual testing so faster!!

@technophile-04 technophile-04 mentioned this pull request Jun 19, 2024
@technophile-04 technophile-04 merged commit bd54b20 into main Jun 20, 2024
1 check passed
@technophile-04 technophile-04 deleted the solidity-frameworks branch June 20, 2024 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants