forked from scaffold-eth/scaffold-eth-2
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cli solidity framework option #58
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
carletex
reviewed
Jun 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is nice !! Thanks @rin-st !! added a couple of nitpicks but looks great already!
yarn cli ../test-712 -e eip-712 -f hardhat -i
This is gonna make scaffolding project while manual testing so faster!!
Merged
technophile-04
approved these changes
Jun 20, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved from scaffold-eth#801
Copy of description
Description
Solidity framework option from CLI. It could be a discussion but I think in this case it's easier to discuss when you already see the code. Feel free to add suggestions 🙂
usage examples (dev):
In case of several solidity framework flags, last will be taken
Other options I thought about.
--hardhat
,--foundry
and--skip-solidity-framework
. Looks bad. Need to check if two or more flags chosen and add additionalif
s to fix/throw error--extensions
flag. It's not clear how to add let's saynone
, and how to mix it with other extensions non-related to solidity frameworksNot sure how it will work with nested extensions but I think it's not a problem to update recurring logic if needed.
Also in this pr I added error if both
--install
and--skip-install
chosenThanks!