Fix issue of non-reseting prefixes

[bgriffith]

Fixes an issue where any modification to the prefixes array when testing using assertions gets carried across to the next. The issue is fixed by always setting the initial prefixes each time an assertion is run.

Closes #182

DCO 1.1 Signed-off-by: Ben Griffith [email protected]

[DanPurdy]

I'm not sure about this.. We are adding extra steps to the linter to fix issues with our tests, this seems completely backwards to me, we should alter the way tests are set and run rather than modify the listing functionality?

[bgriffith]

This only resets the prefixes for the rule. Assertions shouldn't be modifying code for the next one. Each assertion should have equal conditions.

I noticed this issue when I create another assertion using the defaults and received a different amount of warnings compared to the first time it had run.

[DanPurdy]

As we just discussed, I don't think the prefixes should be set within the module itself, though having the default prefixes as immutable within is good and a copy of this array should be the one we mutate. This will prevent the problem in the tests and also be just general good practice..

[bgriffith]

Yep agreed! Update pushed.

[bgriffith]

Going to tighten this up further.

[DanPurdy]

Yeah this makes sense. 👍