Merge pull request #183 from bgriffith/feature/reset-prefix-array-on-…

…new-assertion

Fix issue of non-reseting prefixes

lib/rules/no-vendor-prefixes.js

@@ -4,35 +4,42 @@ var helpers = require('../helpers');
 
 var prefixes = ['webkit', 'moz', 'ms'];
 
-var handleExcludes = function (excludes) {
+var getPrefixCopy = function (prefixArr) {
+  return prefixArr.slice();
+};
+
+var handleExcludes = function (prefixArr, excludes) {
   excludes.forEach(function (item) {
-    var index = prefixes.indexOf(item);
+    var index = prefixArr.indexOf(item);
 
     if (index > -1) {
-      prefixes.splice(index, 1);
+      prefixArr.splice(index, 1);
     }
   });
+
+  return prefixArr;
 };
 
-var handleIncludes = function (includes) {
+var handleIncludes = function (prefixArr, includes) {
   includes.forEach(function (item) {
-    if (prefixes.indexOf(item) === -1) {
-      prefixes.push(item);
+    if (prefixArr.indexOf(item) === -1) {
+      prefixArr.push(item);
     }
   });
-};
 
-var precompileRegEx = function (includes, excludes) {
+  return prefixArr;
+};
 
+var precompileRegEx = function (prefixArr, includes, excludes) {
   if (includes.length) {
-    handleIncludes(includes);
+    prefixArr = handleIncludes(prefixArr, includes);
   }
 
   if (excludes.length) {
-    handleExcludes(excludes);
+    prefixArr = handleExcludes(prefixArr, excludes);
   }
 
-  return new RegExp('-(' + prefixes.join('|') + ')-');
+  return new RegExp('-(' + prefixArr.join('|') + ')-');
 };
 
 module.exports = {
@@ -42,8 +49,10 @@ module.exports = {
     'excluded-identifiers': []
   },
   'detect': function (ast, parser) {
+
     var result = [],
-        statement = precompileRegEx(parser.options['additional-identifiers'], parser.options['excluded-identifiers']);
+        validPrefixes = getPrefixCopy(prefixes),
+        statement = precompileRegEx(validPrefixes, parser.options['additional-identifiers'], parser.options['excluded-identifiers']);
 
     ast.traverseByType('ident', function (value) {
       if (statement.test(value.content)) {

tests/rules/no-vendor-prefixes.js

@@ -61,7 +61,7 @@ describe('no vendor prefix', function () {
         }
       ]
     }, function (data) {
-      lint.assert.equal(2, data.warningCount);
+      lint.assert.equal(6, data.warningCount);
       done();
     });
   });