-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the expected output for str-slice(). #997
Conversation
When is `$end-at` is more negative than the length of the string return an empty string. Fixes sass#2240 Spec sass/sass-spec#997
I'm not sure I completely follow the issue. Can you please confirm what the output of the following should be? a {
test-11: str-slice('aöc', 0, -3);
test-12: str-slice('aöc', 1, -3);
test-16: str-slice('aöc', 0, -4);
test-17: str-slice('aöc', 1, -4);
test-18: str-slice('aöc', 2, -4);
test-19: str-slice('aöc', 3, -4);
} From my understanding they should all return |
@xzyfer |
LibSass fixes this behavior in sass/libsass#2241.
Sorry I'm not clear why these both return
See https://github.com/sass/sass-spec/pull/997/files#diff-2a1fce6f95db3f518285362f272d8e61R18 Seems to run contradictory to your previous comment. |
The spec was updated in sass#997 with incorrect output generated by a big in Ruby Sass sass/sass#2211. This updates the expected output and disables the spec since all implemenations are now failing.
No description provided.