Enable the troublesom str-slice spec for libsass #1005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xzyfer
added a commit
to xzyfer/libsass
that referenced
this pull request
Dec 15, 2016
Fixes sass#2240 (for reals) Spec sass/sass-spec#1005
xzyfer
force-pushed
the
feat/enable-str-slice-libsass
branch
from
bc836ed to
2f02742
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This spec was updated with incorrect output in #997 due to a Ruby
Sass bug. In #1004 the output was updated to be correct and the spec
disabled for all implementations because they all suffered from the
original bug.
This PR enables it for LibSass which is now passing with correct output.