This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
Auto Switch download mirror #2313
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems reasonable to me. Thoughts @nschonni ? |
nschonni
suggested changes
Apr 3, 2018
There was a problem hiding this comment.
I like the idea of this, but 👎 because I think this will end up creating more install issue tickets.
I looked over https://github.com/gucong3000/in-gfw and it looks great, but has a bunch of thinks that will cause people to report issues.
- ES2015 code (so install errors for Node < 4)
- Touches Windows registry, so can cause issues with locked down systems
- Makes network requests through regular
httpmodule that can fall over with weird proxy setups
I think for now we should land the documentation one, and leave this to node-pre-gyp in v5
|
Nice catch. Had a look at the module and I agree. |
|
Merged #2206 instead. Thanks heaps @gucong3000 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.