Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

Add command that configure China mirror #2206

Merged
merged 2 commits into from
Apr 3, 2018
Merged

Conversation

gucong3000
Copy link
Contributor

No description provided.

@nschonni
Copy link
Contributor

nschonni commented Jan 9, 2018

@gucong3000 our install process usually relys on GitHub releases for the binary downloads. Is that also something that is blocked? I know it can fall back to local build if necessary, I'm just curious of the experience with the alternate NPM install.

@xzyfer
Copy link
Contributor

xzyfer commented Jan 9, 2018 via email

@gucong3000
Copy link
Contributor Author

gucong3000 commented Jan 10, 2018

something that is blocked?

Yes, Great Firewall randomly dropp network packets from GitHub and Amazon S3 Service.

China, GitHub and the man-in-the-middle

it can fall back to local build if necessary

Most Web front-end development engineers do not have a compilation environment installed.

It'd be better to general document settings a proxy using npm config

All packages that require download binary package are all need to do that. This is going to be a very tedious and error-prone operation. mirror-config-china will bulk operation for these packages

@xzyfer
Copy link
Contributor

xzyfer commented Feb 20, 2018

This seems reasonable to me. Curious to hear @EdwonLim thoughts since he maintains node-sass-china.

README.md Outdated
### Install from mirror in China

```shell
npx mirror-config-china --registry=http://registry.npm.taobao.org
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be done without adding npx dependency? Something like

npm i -g mirror-config-china --registry=https://registry.npm.taobao.org

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

@xzyfer xzyfer merged commit 909f694 into sass:master Apr 3, 2018
@gucong3000 gucong3000 deleted the patch-1 branch April 3, 2018 15:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants