Fix linux-ia32, linux-arm-musl, and windows-arm64 releases #2265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
On the other hand, |
ntkme
changed the title
ntkme
changed the title
|
Turns out linux-arm-musl was running on the wrong platform. Added another commit to fix that. |
ntkme
commented
Jun 17, 2024
| @@ -19,7 +19,7 @@ jobs: | |||
| platform: linux/amd64 | |||
| - arch: ia32 | |||
| runner: ubuntu-latest | |||
| platform: linux/386 | |||
| platform: linux/amd64 | |||
There was a problem hiding this comment.
Official dart docker image do not have linux/386 support. Use linux/amd64 to build snapshot, as ia32 has no AOT support anyways.
ntkme
commented
Jun 17, 2024
| @@ -19,7 +19,7 @@ jobs: | |||
| platform: linux/amd64 | |||
| - arch: ia32 | |||
| runner: ubuntu-latest | |||
| platform: linux/386 | |||
| platform: linux/amd64 | |||
There was a problem hiding this comment.
This was ok, but updating just to match the linux-ia32 config.
nex3
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nex3 Sorry that my recent commit broken the release CI. This PR should fix it.
https://github.com/sass/dart-sass/actions/runs/9554504858/job/26336030878