Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linux-ia32, linux-arm-musl, and windows-arm64 releases #2265

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Fix linux-ia32, linux-arm-musl, and windows-arm64 releases #2265

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/build-linux-musl.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
platform: linux/amd64
- arch: ia32
runner: ubuntu-latest
platform: linux/386
platform: linux/amd64
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was ok, but updating just to match the linux-ia32 config.

- arch: arm64
runner: linux-arm64
platform: linux/arm64
Expand Down Expand Up @@ -51,7 +51,7 @@ jobs:
- name: Build
run: |
docker run --rm -i \
--platform ${{ matrix.arch == 'arm' && 'linux/amd64' || matrix.platform }} \
--platform ${{ matrix.platform }} \
--volume "$PWD:$PWD" \
--workdir "$PWD" \
ghcr.io/dart-musl/dart <<'EOF'
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build-linux.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
platform: linux/amd64
- arch: ia32
runner: ubuntu-latest
platform: linux/386
platform: linux/amd64
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Official dart docker image do not have linux/386 support. Use linux/amd64 to build snapshot, as ia32 has no AOT support anyways.

- arch: arm64
runner: linux-arm64
platform: linux/arm64
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/build-windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@ jobs:
- arch: ia32
runner: windows-latest
- arch: arm64
runner: windows-arm64
# TODO: switch the following to windows-arm64, blocked by https://github.com/dart-lang/setup-dart/issues/118
runner: windows-latest # windows-arm64

steps:
- uses: actions/checkout@v4
Expand Down
Loading