Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test params #789

Merged
merged 2 commits into from
Dec 7, 2023
Merged

Test params #789

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4eab74a
Testing test parametrize
jbirddog Dec 6, 2023
47a7462
Getting bin_pyl to pass
jbirddog Dec 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions spiffworkflow-backend/tests/spiffworkflow_backend/unit/test_feature_flag_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,20 @@ def no_feature_flags(app: Flask, with_db_and_bpmn_file_cleanup: None) -> Generat
class TestFeatureFlagService(BaseTest):
"""Tests the FeatureFlagService."""

def test_default_enabled_is_respected_when_no_feature_flag_exists(
@pytest.mark.parametrize(
"default_enabled,expected",
[
pytest.param(True, True),
pytest.param(False, False),
],
)
def test_default_enabled_v0(
self,
no_feature_flags: None,
default_enabled: bool,
expected: bool,
) -> None:
assert FeatureFlagService.feature_enabled("some_feature", True)
assert not FeatureFlagService.feature_enabled("another_feature", False)
assert FeatureFlagService.feature_enabled("some_feature", default_enabled) == expected

def test_default_feature_flag_value_overrides_passed_in_default_enabled(
self,
Expand Down
Loading