Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test params #789

Merged
merged 2 commits into from
Dec 7, 2023
Merged

Test params #789

merged 2 commits into from
Dec 7, 2023

Conversation

jbirddog
Copy link
Contributor

@jbirddog jbirddog commented Dec 6, 2023

No strong desire to merge this but just want to see if the new pr stuff is working.

Summary by CodeRabbit

  • Tests
    • Enhanced the feature flag service tests to include parameterized checks, ensuring more robust validation of default feature flag behaviors.

Copy link
Contributor

coderabbitai bot commented Dec 6, 2023

Walkthrough

The update involves refactoring a unit test in the spiffworkflow-backend project. A specific test method that checked the behavior of feature flags when none existed has been transformed into a parameterized test. This allows the test to run multiple scenarios with different input values for default_enabled and check against the expected outcomes.

Changes

File Path Change Summary
.../unit/test_feature_flag_service.py Refactored test_default_enabled_is_respected_when_no_feature_flag_exists to a parameterized test test_default_enabled_v0 with additional parameters default_enabled and expected.

🐇✨
In the realm of code, where tests are king,
A rabbit hopped through, making changes with a zing.
Parameters new, with scenarios to test,
Ensuring feature flags behave at their best. 🚩🎉


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 51250e9 and 47a7462.
Files selected for processing (1)
  • spiffworkflow-backend/tests/spiffworkflow_backend/unit/test_feature_flag_service.py (1 hunks)
Additional comments: 1
spiffworkflow-backend/tests/spiffworkflow_backend/unit/test_feature_flag_service.py (1)
  • 18-31: The parameterized test test_default_enabled_v0 has been correctly implemented to replace the original test method. It uses pytest.mark.parametrize to test different scenarios with the default_enabled and expected parameters. This enhances the test's flexibility and coverage.

@jbirddog jbirddog merged commit beea193 into main Dec 7, 2023
32 checks passed
@jbirddog jbirddog deleted the test_params branch December 7, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants