some nitpicks #120

ronzeiller · 2018-01-10T16:02:44Z

No description provided.

coveralls · 2018-01-10T16:07:27Z

Coverage increased (+0.1%) to 67.81% when pulling c0e9461 on ronzeiller:rz_nitpicks into 9910db5 on sarfata:master.

sarfata · 2018-01-10T16:40:39Z

src/common/signalk/SKNMEAParser.cpp

  windAngle = SKDegToRad(windAngle);
+  SKNormalizeAngle(windAngle);


I think you meant windAngle = SKNormalizeAngle(windAngle);

Yesss :-)

I was finding it incidentally and thought it should be the same as NMEA2000, so 180° is already "from port"

coveralls · 2018-01-11T06:20:31Z

Coverage increased (+0.4%) to 68.082% when pulling 4eb83eb on ronzeiller:rz_nitpicks into 9910db5 on sarfata:master.

coveralls · 2018-01-11T06:24:02Z

Coverage increased (+0.03%) to 67.737% when pulling 86b0b01 on ronzeiller:rz_nitpicks into 9910db5 on sarfata:master.

sarfata · 2018-01-11T06:26:07Z

I fixed a very minor test issue and added a test for the case where wind angle is >180.

⛵️

ronzeiller added 2 commits January 8, 2018 15:45

Typo corrected

f71720c

changed to SKNormalizeAngle

c0e9461

sarfata reviewed Jan 10, 2018

View reviewed changes

ronzeiller and others added 4 commits January 10, 2018 17:51

corrected SKNormalize of wind angle

bf0b183

corrected to normalize radians

1d6856f

fix tests

4eb83eb

add a test for MWV with wind angle > 180

86b0b01

sarfata merged commit 37ee8b3 into sarfata:master Jan 11, 2018

ronzeiller deleted the rz_nitpicks branch February 11, 2018 11:42

Provide feedback

		windAngle = SKDegToRad(windAngle);
		SKNormalizeAngle(windAngle);