Space application supporter deployments wip #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [sequel](https://github.com/jeremyevans/sequel) from 5.44.0 to 5.45.0. - [Release notes](https://github.com/jeremyevans/sequel/releases) - [Changelog](https://github.com/jeremyevans/sequel/blob/master/CHANGELOG) - [Commits](jeremyevans/sequel@5.44.0...5.45.0) --- updated-dependencies: - dependency-name: sequel dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
github issue cloudfoundry#2243 Authored-by: Teal Stannard <[email protected]>
- Add tests that check permissions. - Adjust documentation; "All Roles" are permitted.
- Add 'space_application_supporter' to permission tests. - Remove 'set_current_user_as_role' from "when the user is logged in" context; for this test only the scope (cloud_controller.read) is important.
- Add tests that check permissions. Co-authored-by: Will Gant <[email protected]>
* Refactored v3 Events permissions checks to be in the permissions queryer because we believe that to be the desired pattern + easier to follow. * Updated documentation. [cloudfoundry#2216] Co-authored-by: Carson Long <[email protected]> Co-authored-by: Mona Mohebbi <[email protected]>
Also adds missing table headers for roles tables that have notes, as the absence of these prevents the second column from rendering.
…an update Signed-off-by: Philipp Thun <[email protected]>
Manifest diff changes at the application are now ignored if there isn't a sub attribute.
…e-columns Use a consistent format for roles table notes in API docs
…ion-supporter-events Allow Space Application Supporter access to specific Audit Events endpoints
…lication-supporter-jobs Ensure that space application supporter can access GET /v3/jobs/:guid
…lication-supporter-users Ensure that space application supporter can access user GET endpoints
* Decided to have some fields in v3/droplets/:guid be redacted (in a similar fashion to every role except admin roles and space developers) * Updated documentation * Refactored some of the droplets request specs to use it_behaves_like [cloudfoundry#2220] Co-authored-by: Weyman Fung <[email protected]> Co-authored-by: Carson Long <[email protected]>
…lication-supporter-buildpacks Ensure that space application supporter can get/list buildpacks
… patch test Implements the following comments on PR cloudfoundry#2325: cloudfoundry#2325 (review)
…lication-supporter-environment-variable-groups Space application supporter can access environment variable groups
…dler/sequel-5.45.0 build(deps): bump sequel from 5.44.0 to 5.45.0
…ion-supporter-droplets Allow space application supporter to access specific droplet endpoints
Bundler prefers "with_unbundled_env" over the old "with_clean_env" Co-authored-by: Matthew Kocher <[email protected]> Co-authored-by: Mona Mohebbi <[email protected]>
Co-authored-by: Philipp Thun <[email protected]>
Co-authored-by: Philipp Thun <[email protected]>
Co-authored-by: Philipp Thun <[email protected]>
Co-authored-by: Philipp Thun <[email protected]>
Co-authored-by: Philipp Thun <[email protected]>
This reverts commit a50aef2. See pull request cloudfoundry#2323 for discussion on the decision not to grant the space application supporter access to PATCH endpoints that only allow users to update metadata/labels: cloudfoundry#2323 (comment)
See pull request cloudfoundry#2323 for discussion on the decision not to grant the space application supporter access to PATCH endpoints that only allow users to update metadata/labels: cloudfoundry#2323 (comment)
Signed-off-by: Aftab Alam <[email protected]>
Signed-off-by: Aftab Alam <[email protected]>
Signed-off-by: Aftab Alam <[email protected]>
Signed-off-by: Aftab Alam <[email protected]>
|
Created by mistake - please ignore. |
philippthun
pushed a commit
that referenced
this pull request
Jun 15, 2022
Notable changes in this commit: * Adds an `/internal/v4/metrics` endpoint which serves Prometheus-style metrics. * Adds function to Prometheus::Client::Registry to re-create the library's metrics registry. This is used by the PrometheusClient class's tests to wipe out the metrics registry, which is global state. Global state is the #1 cause of test pollution and this change seemed to be the most straightforward way to eliminate some order-dependent test failures. NOTE: This function definition is only in the `prometheus_updater_spec.rb` file, which we believe is not shipped in capi-release, so the odds of actually writing production code that depends on this test-only functionality are pretty slim. Co-authored-by: David Alvarado <[email protected]> Co-authored-by: Kenneth Lakin <[email protected]> Co-authored-by: Merric de Launey <[email protected]> Co-authored-by: Michael Oleske <[email protected]>
will-gant
pushed a commit
that referenced
this pull request
Dec 16, 2022
Notable changes in this commit: * Adds an `/internal/v4/metrics` endpoint which serves Prometheus-style metrics. * Adds function to Prometheus::Client::Registry to re-create the library's metrics registry. This is used by the PrometheusClient class's tests to wipe out the metrics registry, which is global state. Global state is the #1 cause of test pollution and this change seemed to be the most straightforward way to eliminate some order-dependent test failures. NOTE: This function definition is only in the `prometheus_updater_spec.rb` file, which we believe is not shipped in capi-release, so the odds of actually writing production code that depends on this test-only functionality are pretty slim. Co-authored-by: David Alvarado <[email protected]> Co-authored-by: Kenneth Lakin <[email protected]> Co-authored-by: Merric de Launey <[email protected]> Co-authored-by: Michael Oleske <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.