Allow Space Application Supporter access to specific Audit Events endpoints #2324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Refactored v3 Events permissions checks to be in the permissions queryer because we believe that to be the desired pattern + easier to follow. * Updated documentation. [#2216] Co-authored-by: Carson Long <[email protected]> Co-authored-by: Mona Mohebbi <[email protected]>
ctlong
changed the title
ctlong
added
the
space-application-supporter
monamohebbi
approved these changes
Jun 10, 2021
sweinstein22
approved these changes
Jun 10, 2021
There was a problem hiding this comment.
Did a quick check to make sure the output matched up between space devs and space application supporters for the two endpoints, GET /v3/audit_events/:guid and GET /v3/audit_events. Confirmed that we now have permissions tests for both endpoints, and the refactor looks good!
Checked for the docs changes, everything looks good! Thanks for catching the stray alphabetization ordering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also refactored v3 Events permissions checks to be in the permissions queryer because we believe that to be the desired pattern + it seems easier to follow. We also updated the documentation.
Closes #2216
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests