feat(cli): build user peer-deps #6742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎ To accept the risk, merge this PR and you will not be notified again.
Next stepsWhat is an install script?Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts. Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead. Take a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with
|
|
No changes to documentation |
|
Component Testing Report Updated May 28, 2024 5:55 PM (UTC)
|
binoy14
reviewed
May 24, 2024
packages/sanity/src/_internal/cli/server/__tests__/buildVendorDependencies.test.ts
Show resolved
Hide resolved
* feat: create import map w/ installed sanity version * fix: use correct URL
binoy14
approved these changes
May 28, 2024
binoy14
pushed a commit
that referenced
this pull request
May 28, 2024
* feat(cli): build user peer-deps * chore: remove shared-modules build * test(cli): verify build config and `exports` subpaths * text(cli): add depcheck config for fixture projects * docs: update comments and test name * feat: create import map w/ installed sanity version (#6784) * feat: create import map w/ installed sanity version * fix: use correct URL
binoy14
pushed a commit
that referenced
this pull request
May 29, 2024
* feat(cli): build user peer-deps * chore: remove shared-modules build * test(cli): verify build config and `exports` subpaths * text(cli): add depcheck config for fixture projects * docs: update comments and test name * feat: create import map w/ installed sanity version (#6784) * feat: create import map w/ installed sanity version * fix: use correct URL
binoy14
pushed a commit
that referenced
this pull request
May 30, 2024
* feat(cli): build user peer-deps * chore: remove shared-modules build * test(cli): verify build config and `exports` subpaths * text(cli): add depcheck config for fixture projects * docs: update comments and test name * feat: create import map w/ installed sanity version (#6784) * feat: create import map w/ installed sanity version * fix: use correct URL
binoy14
pushed a commit
that referenced
this pull request
May 30, 2024
* feat(cli): build user peer-deps * chore: remove shared-modules build * test(cli): verify build config and `exports` subpaths * text(cli): add depcheck config for fixture projects * docs: update comments and test name * feat: create import map w/ installed sanity version (#6784) * feat: create import map w/ installed sanity version * fix: use correct URL
binoy14
pushed a commit
that referenced
this pull request
May 31, 2024
* feat(cli): build user peer-deps * chore: remove shared-modules build * test(cli): verify build config and `exports` subpaths * text(cli): add depcheck config for fixture projects * docs: update comments and test name * feat: create import map w/ installed sanity version (#6784) * feat: create import map w/ installed sanity version * fix: use correct URL
binoy14
pushed a commit
that referenced
this pull request
Jun 10, 2024
* feat(cli): build user peer-deps * chore: remove shared-modules build * test(cli): verify build config and `exports` subpaths * text(cli): add depcheck config for fixture projects * docs: update comments and test name * feat: create import map w/ installed sanity version (#6784) * feat: create import map w/ installed sanity version * fix: use correct URL
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 11, 2024
* feat: add CLI options to enable auto-updating studios * refactor(cli): prefix with `unstable_` * test: Update packages/sanity/src/_internal/cli/server/renderDocument.ts Co-authored-by: Espen Hovlandsdal <[email protected]> * chore(core): update import map urls * feat(cli): build user peer-deps (#6742) * feat(cli): build user peer-deps * chore: remove shared-modules build * test(cli): verify build config and `exports` subpaths * text(cli): add depcheck config for fixture projects * docs: update comments and test name * feat: create import map w/ installed sanity version (#6784) * feat: create import map w/ installed sanity version * fix: use correct URL * chore(cli): rename auto updates flag --------- Co-authored-by: Espen Hovlandsdal <[email protected]> Co-authored-by: Binoy Patel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the
buildVendorDependenciesfunction which builds ESM browser-compatible versions of specified vendor packages. It includes a robust mechanism for handling semver versions, carefully considering major, minor, and patch version changes. The rationale is to ensure stability and flexibility by adding support for new subpath exports as needed. Read the TSDoc comment for more info.What to review
buildVendorDependenciesfunction implementation.fileSystemprop.Testing
vite.buildalong with some new fixtures example project to test that the resolution works as expected.Notes for release
Not applicable to the release at this time. This should be merged into #6514 first.