feat: add CLI options to enable auto-updating studios #6514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
No changes to documentation |
|
Component Testing Report Updated Jun 10, 2024 7:39 PM (UTC)
|
binoy14
reviewed
Apr 29, 2024
ricokahler
requested review from
a team and
hermanwikner
and removed request for
a team
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
Co-authored-by: Espen Hovlandsdal <[email protected]>
* feat(cli): build user peer-deps * chore: remove shared-modules build * test(cli): verify build config and `exports` subpaths * text(cli): add depcheck config for fixture projects * docs: update comments and test name * feat: create import map w/ installed sanity version (#6784) * feat: create import map w/ installed sanity version * fix: use correct URL
binoy14
reviewed
Jun 11, 2024
| if (autoUpdatesEnabled) { | ||
| const version = encodeURIComponent(`^${installedSanityVersion}`) | ||
| const autoUpdatesImports = { | ||
| 'sanity': `https://api.sanity.work/v1/modules/sanity/default/${version}`, |
There was a problem hiding this comment.
note this is changing in a PR in in the stack above
binoy14
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the
--enable-auto-updatesandunstable_enableAutoUpdatesflags to the CLI build options and config.Additionally this PR:
importMapsupport torenderDocumentandsanityBuildEntriesvianode-html-parser(see tests)Note that this will only affect the built version of the Studio and local versions will not use import maps. This decision was made because we did not want to provide a react dev build however this could potentially be possible now with import maps.
What to review
Testing
I added tests and I tried this out in the test-studio locally.
Notes for release
N/A