Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unconditional external from vite build #6554

Merged
merged 1 commit into from
May 3, 2024

Conversation

ricokahler
Copy link
Contributor

Description

This one is just a quick follow up for #6394.

I merged @binoy14's PR to unblock another item i'm working on and I later found out that there was an unconditional thing that should've been deactivated. #6514 is a better fix but this should go in now. Apologies for any noise.

Notes for release

N/A

@ricokahler ricokahler requested a review from a team as a code owner May 3, 2024 07:14
@ricokahler ricokahler requested review from bjoerge and removed request for a team May 3, 2024 07:14
Copy link

vercel bot commented May 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview May 3, 2024 7:16am
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 3, 2024 7:16am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 3, 2024 7:16am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) May 3, 2024 7:16am

Copy link
Contributor

github-actions bot commented May 3, 2024

No changes to documentation

Copy link
Contributor

github-actions bot commented May 3, 2024

Component Testing Report Updated May 3, 2024 7:21 AM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 35s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 6s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 25s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 20s 6 3 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 13s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 35s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 3s 15 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 3s 18 0 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 20s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 14s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 21s 9 0 0

@ricokahler ricokahler added this pull request to the merge queue May 3, 2024
Merged via the queue into next with commit f1e9546 May 3, 2024
37 of 38 checks passed
@ricokahler ricokahler deleted the fix/remove-external-from-vite-build branch May 3, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants