-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sanic routing #2010
Sanic routing #2010
Conversation
This pull request has been mentioned on Sanic Community Discussion. There might be relevant details there: https://community.sanicframework.org/t/a-fast-new-router/649/38 |
Looking great! |
Requires: sanic-org/sanic-testing#13 |
Codecov Report
@@ Coverage Diff @@
## master #2010 +/- ##
==========================================
+ Coverage 91.45% 92.13% +0.68%
==========================================
Files 28 33 +5
Lines 3171 3104 -67
Branches 571 542 -29
==========================================
- Hits 2900 2860 -40
+ Misses 192 165 -27
Partials 79 79
Continue to review full report at Codecov.
|
Passing tests except for Python 3.6 with uvloop. See #2024 |
Fixes #1671 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great
Implementation of sanic-routing. Currently, it is written as a dependency. Whether it stays that way or is merged into this repo is up for discussion at a later date.
Besides overhauling the Router to use the compiled version, this also hits the following:
Blueprint
andSanic
into mixinslikelytouch on some consistency with naming of routes,I am divided on this but if we are going to break it, then we should do it now@app.before_server_start
@app.after_server_start
@app.before_server_stop
@app.after_server_stop
@app.on_request
@app.on_response
Allow
header that did not includeHEAD
request.match_info
is now a cached (and not computed) propertyapplication/octet-stream
_host
keyword inurl_for
str
,float
, orint
ctx
propertyroutes_static
,routes_dynamic
,routes_regex
See discussion