Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Websocket subprotocols on Blueprint decorator #1233

Closed
ahopkins opened this issue May 30, 2018 · 4 comments
Closed

Websocket subprotocols on Blueprint decorator #1233

ahopkins opened this issue May 30, 2018 · 4 comments

Comments

@ahopkins
Copy link
Member

ahopkins commented May 30, 2018

Subprotocols do not seem to be included on blueprint websockets.

I see this on the Sanic.websocket class, but not on Blueprint.websocket.

Any way we could add that feature?

See #874

@sjsadowski
Copy link
Contributor

@ahopkins #1214

@ahopkins
Copy link
Member Author

Let's leave this one open for now ... but I think there is more discussion to be had that is probably more appropriate under #1214 .

@stale
Copy link

stale bot commented May 14, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this is incorrect, please respond with an update. Thank you for your contributions.

@ahopkins
Copy link
Member Author

Resolved by #2010

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants