Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1989 Add disable app registry #1993

Merged
merged 7 commits into from
Jan 5, 2021
Merged

#1989 Add disable app registry #1993

merged 7 commits into from
Jan 5, 2021

Conversation

ahopkins
Copy link
Member

@ahopkins ahopkins commented Jan 5, 2021

  • Adds a new config value REGISTER that disables registering an app.
  • Adds Sanic(..., register=False) to disable registering a single app instance

See #1989

This was referenced Jan 5, 2021
Merged
Merged
@codecov
Copy link

codecov bot commented Jan 5, 2021 •
edited
Loading

Codecov Report

Merging #1993 (d11ec19) into master (150d75b) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1993      +/-   ##
==========================================
- Coverage   92.88%   92.79%   -0.09%     
==========================================
  Files          29       29              
  Lines        3259     3262       +3     
  Branches      569      571       +2     
==========================================
  Hits         3027     3027              
- Misses        157      159       +2     
- Partials       75       76       +1
Impacted Files Coverage Δ
sanic/config.py 100.00% <ø> (ø)
sanic/app.py 96.02% <100.00%> (+0.02%) ⬆️
sanic/server.py 81.61% <0.00%> (-0.57%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 150d75b...d11ec19. Read the comment docs.

vltr
vltr approved these changes Jan 5, 2021
View reviewed changes
Copy link
Member

@vltr vltr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me - for legacy purposes, mostly.

@ahopkins ahopkins merged commit 206992f into master Jan 5, 2021
ahopkins added a commit that referenced this pull request Jan 5, 2021
@ahopkins
#1993 Disable registry (#1994)
fe3fdc5 
* Bump to v20.12 (#1987)

* Bump to v20.12

* Update Changelog

* Add disable app registry

* squash

* Create FUNDING.yml (#1995)
ahopkins added a commit that referenced this pull request Jan 7, 2021
@ahopkins
20.12 lts (#1996)
fcdbeb7 
* Bump to v20.12

* Update Changelog

* #1993 Disable registry (#1994)

* Bump to v20.12 (#1987)

* Bump to v20.12

* Update Changelog

* Add disable app registry

* squash

* Create FUNDING.yml (#1995)
@ahopkins ahopkins deleted the disable-registry branch January 11, 2021 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vltr vltr vltr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahopkins @vltr