-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for PyJwt_2_0_0 #206
Conversation
Looks like I need to fix the Travis builds. Will look into that next week and get this merged. Thanks for the PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also update the requirements?
Updated setup.py |
Can you take a look at the failing tests? |
2) Fix some tests 3) Freeze sanic version to 20.9.1, otherwise tests would fail.
Codecov Report
@@ Coverage Diff @@
## master #206 +/- ##
=======================================
Coverage 97.71% 97.71%
=======================================
Files 12 12
Lines 1049 1050 +1
Branches 174 174
=======================================
+ Hits 1025 1026 +1
Misses 15 15
Partials 9 9
Continue to review full report at Codecov.
|
Hi @ahopkins: I have fixed the tests. The suite is failing due to some issues with coverage, probably some configuration issues. I will try to have a look but if you know what this is about then that's better |
I have commented out the coverage combine command for now, since there aren't multiple coverage files to combine. |
Happy new year guys. Any idea when this PR might get merged into master and released. |
@ahopkins : I am freezing this project dependency on sanic - 20.9.1. Due to sanic-org/sanic#1989 for now. Either I can make those changes you suggested there or wait for sanic for the patch. |
I am pushing out a patch for that shortly. |
See #1993. Will also merge to release as 20.12.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small change to overcome the name registry and then ready to merge.
tox.ini
Outdated
@@ -24,7 +24,7 @@ deps = | |||
pytest-flakes | |||
pytest-pep8 | |||
pytest-travis-fold | |||
sanic | |||
sanic==20.9.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not going to merge this with a 20.9 dependency.
Just add this line to the top of conftest.py
after the imports.
Sanic.test_mode = True
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the coming weeks, we will release: https://github.com/sanic-org/sanic-test
It will automatically set that.
Released. Thank you 👏 |
Goal
PyJWT just released v2.0.0 which breaks sanic-jwt due to jpadilla/pyjwt#529
Approach
Type checking before returning access token.