Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making static route more verbose if file not found #1945

Merged
merged 10 commits into from
Dec 28, 2020
Merged

Making static route more verbose if file not found #1945

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
bc02ddf
Improve FileNotFound exception
tomaszdrozdz Sep 30, 2020
d1ecb19
Another idea.
tomaszdrozdz Oct 1, 2020
284d33d
Another idea.
tomaszdrozdz Oct 1, 2020
f404821
Implementing advice.
tomaszdrozdz Oct 2, 2020
a1e2fc1
Work ongoing.
tomaszdrozdz Oct 2, 2020
3f538fa
Merge branch 'master' into Making-static-route-more-verbose-if-file-n…
ahopkins Oct 24, 2020
a515b16
Merge branch 'master' into Making-static-route-more-verbose-if-file-n…
ahopkins Oct 25, 2020
7ec1e0d
Merge branch 'master' into Making-static-route-more-verbose-if-file-n…
ahopkins Nov 29, 2020
95cbfd6
Fix linting issues
ahopkins Dec 28, 2020
684b6b6
Merge branch 'master' into Making-static-route-more-verbose-if-file-n…
ahopkins Dec 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions sanic/static.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
InvalidUsage,
)
from sanic.handlers import ContentRangeHandler
from sanic.log import error_logger
from sanic.response import HTTPResponse, file, file_stream


Expand Down Expand Up @@ -40,6 +41,10 @@ async def _static_request_handler(
# match filenames which got encoded (filenames with spaces etc)
file_path = path.abspath(unquote(file_path))
if not file_path.startswith(path.abspath(unquote(root_path))):
error_logger.exception(
f"File not found: path={file_or_directory}, "
f"relative_url={file_uri}"
)
raise FileNotFound(
"File not found", path=file_or_directory, relative_url=file_uri
)
Expand Down Expand Up @@ -94,6 +99,10 @@ async def _static_request_handler(
except ContentRangeError:
raise
except Exception:
error_logger.exception(
f"File not found: path={file_or_directory}, "
f"relative_url={file_uri}"
)
raise FileNotFound(
"File not found", path=file_or_directory, relative_url=file_uri
)
Expand Down