Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making static route more verbose if file not found #1945

Conversation

tomaszdrozdz
Copy link
Contributor

@ahopkins something like that ? (contnuation of #1941)

ahopkins
ahopkins previously approved these changes Oct 24, 2020
@codecov
Copy link

codecov bot commented Nov 29, 2020

Codecov Report

Merging #1945 (684b6b6) into master (449bc41) will decrease coverage by 0.11%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1945      +/-   ##
==========================================
- Coverage   92.81%   92.69%   -0.12%     
==========================================
  Files          29       29              
  Lines        3256     3259       +3     
  Branches      569      569              
==========================================
- Hits         3022     3021       -1     
- Misses        158      161       +3     
- Partials       76       77       +1     
Impacted Files Coverage Δ
sanic/static.py 92.85% <66.66%> (-1.18%) ⬇️
sanic/server.py 81.05% <0.00%> (-0.57%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 449bc41...684b6b6. Read the comment docs.

@ahopkins
Copy link
Member

ahopkins commented Dec 9, 2020

Can we get these passing so we can include in the upcoming release?

@ahopkins ahopkins merged commit 7475897 into sanic-org:master Dec 28, 2020
@ahopkins ahopkins mentioned this pull request Dec 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants