-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Making static route more verbose if file not found #1945
Merged
ahopkins
merged 10 commits into
sanic-org:master
from
tomaszdrozdz:Making-static-route-more-verbose-if-file-not-found
Dec 28, 2020
Merged
Making static route more verbose if file not found #1945
ahopkins
merged 10 commits into
sanic-org:master
from
tomaszdrozdz:Making-static-route-more-verbose-if-file-not-found
Dec 28, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahopkins
previously approved these changes
Oct 24, 2020
Codecov Report
@@ Coverage Diff @@
## master #1945 +/- ##
==========================================
- Coverage 92.81% 92.69% -0.12%
==========================================
Files 29 29
Lines 3256 3259 +3
Branches 569 569
==========================================
- Hits 3022 3021 -1
- Misses 158 161 +3
- Partials 76 77 +1
Continue to review full report at Codecov.
|
Can we get these passing so we can include in the upcoming release? |
ahopkins
approved these changes
Dec 28, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ahopkins something like that ? (contnuation of #1941)