Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport to 1912 #1900

Merged
merged 3 commits into from
Jul 29, 2020
Merged

Backport to 1912 #1900

merged 3 commits into from
Jul 29, 2020

Conversation

ahopkins
Copy link
Member

See #1849

@codecov
Copy link

codecov bot commented Jul 29, 2020

Codecov Report

Merging #1900 into 19.12LTS will decrease coverage by 2.71%.
The diff coverage is 57.14%.

Impacted file tree graph

@@             Coverage Diff              @@
##           19.12LTS    #1900      +/-   ##
============================================
- Coverage     92.30%   89.59%   -2.72%     
============================================
  Files            22       25       +3     
  Lines          2274     2930     +656     
  Branches        419      543     +124     
============================================
+ Hits           2099     2625     +526     
- Misses          135      233      +98     
- Partials         40       72      +32     
Impacted Files Coverage Δ
sanic/server.py 74.83% <16.66%> (ø)
sanic/app.py 91.91% <84.61%> (-0.35%) ⬇️
sanic/response.py 100.00% <100.00%> (ø)
sanic/worker.py 82.64% <0.00%> (-0.15%) ⬇️
sanic/router.py 95.49% <0.00%> (-0.07%) ⬇️
sanic/request.py 99.60% <0.00%> (-0.03%) ⬇️
sanic/testing.py 97.91% <0.00%> (-0.03%) ⬇️
sanic/views.py 100.00% <0.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb9ff7c...4df75b2. Read the comment docs.

@ahopkins ahopkins merged commit 2a44a27 into 19.12LTS Jul 29, 2020
@ahopkins ahopkins deleted the backport_to_1912 branch July 29, 2020 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants