Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick PRs to backport to 19.12LTS #1849

Closed

Conversation

ashleysommer
Copy link
Member

Includes fixes from:
#1762
#1764
#1789

@ashleysommer
Copy link
Member Author

Travis Type Checks are failing because 19.12LTS branch was never expected to have that level of type checking on it. The failures are not related to the commits in this PR.

@ahopkins
Copy link
Member

@sjsadowski Let's try and circle back up on this early next week to get this built and pushed.

@ahopkins
Copy link
Member

#1779?

@ashleysommer
Copy link
Member Author

Oh, I didn't know #1779 exists. Though it looks like a rollup up a lot more commits between end of December 2019 and February 2020. I'll comment in that PR.

@ashleysommer ashleysommer mentioned this pull request May 14, 2020
@Tronic Tronic added the needs review the PR appears ready but requires a review label Jun 21, 2020
@ashleysommer
Copy link
Member Author

Double checking everything on this, tests look fine (just a couple of mypy fails in asgi.py unrelated to these changes).

@codecov
Copy link

codecov bot commented Jul 29, 2020

Codecov Report

Merging #1849 into 19.12LTS will decrease coverage by 2.81%.
The diff coverage is 57.14%.

Impacted file tree graph

@@             Coverage Diff              @@
##           19.12LTS    #1849      +/-   ##
============================================
- Coverage     92.30%   89.48%   -2.82%     
============================================
  Files            22       25       +3     
  Lines          2274     2930     +656     
  Branches        419      543     +124     
============================================
+ Hits           2099     2622     +523     
- Misses          135      235     +100     
- Partials         40       73      +33     
Impacted Files Coverage Δ
sanic/server.py 74.15% <16.66%> (ø)
sanic/app.py 91.91% <84.61%> (-0.35%) ⬇️
sanic/response.py 100.00% <100.00%> (ø)
sanic/worker.py 82.64% <0.00%> (-0.15%) ⬇️
sanic/router.py 95.49% <0.00%> (-0.07%) ⬇️
sanic/request.py 99.60% <0.00%> (-0.03%) ⬇️
sanic/testing.py 97.91% <0.00%> (-0.03%) ⬇️
sanic/views.py 100.00% <0.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb9ff7c...abca1fc. Read the comment docs.

This was referenced Jul 29, 2020
@ahopkins
Copy link
Member

@ashleysommer GitHub was complaining and would not let me push to your branch. So I created a new branch here and a new PR: #1900.

@ahopkins ahopkins closed this Jul 29, 2020
@ahopkins ahopkins removed the needs review the PR appears ready but requires a review label Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants