-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cherry pick PRs to backport to 19.12LTS #1849
Conversation
Includes commits from: sanic-org#1762 sanic-org#1764 sanic-org#1789
Travis Type Checks are failing because 19.12LTS branch was never expected to have that level of type checking on it. The failures are not related to the commits in this PR. |
@sjsadowski Let's try and circle back up on this early next week to get this built and pushed. |
Oh, I didn't know #1779 exists. Though it looks like a rollup up a lot more commits between end of December 2019 and February 2020. I'll comment in that PR. |
Double checking everything on this, tests look fine (just a couple of mypy fails in asgi.py unrelated to these changes). |
Codecov Report
@@ Coverage Diff @@
## 19.12LTS #1849 +/- ##
============================================
- Coverage 92.30% 89.48% -2.82%
============================================
Files 22 25 +3
Lines 2274 2930 +656
Branches 419 543 +124
============================================
+ Hits 2099 2622 +523
- Misses 135 235 +100
- Partials 40 73 +33
Continue to review full report at Codecov.
|
@ashleysommer GitHub was complaining and would not let me push to your branch. So I created a new branch here and a new PR: #1900. |
Includes fixes from:
#1762
#1764
#1789