Add handler names for websockets for url_for usage #1880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tronic
approved these changes
Jun 28, 2020
Comment on lines
+37
to
+39
| f.write( | ||
| dedent( | ||
| f"""\ |
There was a problem hiding this comment.
I suppose this was by linter because the original formatting was better. Maybe reindent the rest of the string literal too to match the extra level at opening?
There was a problem hiding this comment.
Yes. make fix-import
Oh trust in the almighty black.
Codecov Report
@@ Coverage Diff @@
## master #1880 +/- ##
=======================================
Coverage 91.70% 91.70%
=======================================
Files 27 27
Lines 3000 3001 +1
Branches 544 544
=======================================
+ Hits 2751 2752 +1
Misses 171 171
Partials 78 78
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accomplishes what #1696 set out to do, but was unable after change to #1853