Fix pickle error when attempting to pickle an application which contains websocket routes #1853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ins websocket routes. Moves the websocket_handler subfunction out to a class-level method, which can be more easily pickled by the built-in python Pickler. Also includes a similar fix for the add_task deferred task scheduler subfunction.
Codecov Report
@@ Coverage Diff @@
## master #1853 +/- ##
==========================================
+ Coverage 91.63% 91.80% +0.16%
==========================================
Files 27 27
Lines 3000 3000
Branches 545 544 -1
==========================================
+ Hits 2749 2754 +5
+ Misses 172 169 -3
+ Partials 79 77 -2
Continue to review full report at Codecov.
|
ahopkins
approved these changes
Jun 3, 2020
|
@ahopkins just a heads up, I don't think the one line change in server.py was supposed to be part of this fix, it might've been an accidental inclusion. I'll double check. |
This was referenced Jun 28, 2020
ashleysommer
added a commit
that referenced
this pull request
Jun 29, 2020
Revert change to multiprocessing mode accidentally included in #1853
ahopkins
added a commit
that referenced
this pull request
Jun 29, 2020
Revert change to multiprocessing mode accidentally included in #1853 Co-authored-by: Adam Hopkins <[email protected]>
ahopkins
added a commit
that referenced
this pull request
Jun 29, 2020
Revert change to multiprocessing mode accidentally included in #1853 Co-authored-by: Adam Hopkins <[email protected]>
|
This pull request has been mentioned on Sanic Community Discussion. There might be relevant details there: https://community.sanicframework.org/t/multiprocessing-is-currently-not-supported-on-nt/827/2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar fix to PR #1842, this fixes the same problem but for websocket routes.
Moves the
websocket_handlersubfunction out to a class-level method, which can be more easily pickled by the built-in python Pickler.Also includes a small addition of the same fix for the
app.add_task()deferred task scheduler subfunction.