Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix-#1856: adjust websockets version to setup.py and make nightly (py39) tests pass #1857

Merged
merged 6 commits into from
Jun 28, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sanic/websocket.py
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ async def websocket_handshake(self, request, subprotocols=None):

# hook up the websocket protocol
self.websocket = WebSocketCommonProtocol(
timeout=self.websocket_timeout,
close_timeout=self.websocket_timeout,
max_size=self.websocket_max_size,
max_queue=self.websocket_max_queue,
read_limit=self.websocket_read_limit,
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ def open_local(paths, mode="r", encoding="utf8"):
uvloop,
ujson,
"aiofiles>=0.3.0",
"websockets>=7.0,<9.0",
"websockets>=8.1,<9.0",
"multidict>=4.0,<5.0",
"httpx==0.11.1",
]
Expand Down
6 changes: 4 additions & 2 deletions tests/test_reloader.py
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
import os
import secrets
import sys
from contextlib import suppress

from subprocess import PIPE, Popen
from subprocess import PIPE, Popen, TimeoutExpired
from tempfile import TemporaryDirectory
from textwrap import dedent
from threading import Timer
Expand Down Expand Up @@ -85,4 +86,5 @@ async def test_reloader_live(runargs, mode):
finally:
timeout.cancel()
terminate(proc)
proc.wait(timeout=3)
with suppress(TimeoutExpired):
proc.wait(timeout=3)
2 changes: 1 addition & 1 deletion tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ deps =
gunicorn
pytest-benchmark
uvicorn
websockets>=7.0,<8.0
websockets>=8.1,<9.0
commands =
pytest {posargs:tests --cov sanic}
- coverage combine --append
Expand Down