Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix-#1856: adjust websockets version to setup.py and make nightly (py39) tests pass #1857

Merged
merged 6 commits into from
Jun 28, 2020

Conversation

DavidBord
Copy link
Contributor

Fixes #1856

@codecov
Copy link

codecov bot commented May 16, 2020

Codecov Report

Merging #1857 into master will decrease coverage by 3.18%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1857      +/-   ##
==========================================
- Coverage   94.81%   91.62%   -3.19%     
==========================================
  Files          24       27       +3     
  Lines        2314     2998     +684     
  Branches      422      544     +122     
==========================================
+ Hits         2194     2747     +553     
- Misses         75      172      +97     
- Partials       45       79      +34     
Impacted Files Coverage Δ
sanic/websocket.py 88.63% <ø> (ø)
sanic/server.py 74.33% <0.00%> (ø)
sanic/blueprints.py 95.94% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bedf68a...5387b2f. Read the comment docs.

Copy link
Member

@ahopkins ahopkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we do not even want to be using 0.7.0 any more. I do not think this is the right version to be setting this too.

python-websockets/websockets#760 (comment)

@DavidBord
Copy link
Contributor Author

@ahopkins you want me to change the minimal supported websockets version to be 8.1?

@ahopkins
Copy link
Member

ahopkins commented May 18, 2020

Yes. let's see what it breaks. I think there was a change with the handling of subprotocols.

Or, perhaps even better, rather than dropping that out now, let's throw a warning in there (if using v7) that we will up the requirements after the next LTS.

@DavidBord
Copy link
Contributor Author

@ahopkins to accomplish what you wrote in your last comment I think we'll have to either have non matching websockets versions between setup.py & tox.ini or keep py3.9 tests failing.

ahopkins
ahopkins previously approved these changes Jun 3, 2020
@Tronic
Copy link
Member

Tronic commented Jun 21, 2020

Unrelated test failure, possibly a random mishap in test_reloader that'll need to be addressed in another PR. This one is good to go if only the test failure can be bypassed/ignored.

@ahopkins ahopkins merged commit 1b324ae into sanic-org:master Jun 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nightly build fails due to websockets version not matching setup.py
4 participants