-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix-#1856: adjust websockets version to setup.py and make nightly (py39) tests pass #1857
Conversation
…ghtly (py39) tests pass
Codecov Report
@@ Coverage Diff @@
## master #1857 +/- ##
==========================================
- Coverage 94.81% 91.62% -3.19%
==========================================
Files 24 27 +3
Lines 2314 2998 +684
Branches 422 544 +122
==========================================
+ Hits 2194 2747 +553
- Misses 75 172 +97
- Partials 45 79 +34
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we do not even want to be using 0.7.0
any more. I do not think this is the right version to be setting this too.
@ahopkins you want me to change the minimal supported websockets version to be 8.1? |
Yes. let's see what it breaks. I think there was a change with the handling of subprotocols. Or, perhaps even better, rather than dropping that out now, let's throw a warning in there (if using v7) that we will up the requirements after the next LTS. |
@ahopkins to accomplish what you wrote in your last comment I think we'll have to either have non matching websockets versions between setup.py & tox.ini or keep py3.9 tests failing. |
Unrelated test failure, possibly a random mishap in test_reloader that'll need to be addressed in another PR. This one is good to go if only the test failure can be bypassed/ignored. |
Fixes #1856