Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove server config args that can be read directly from app. #1807

Merged
merged 4 commits into from
Apr 9, 2020

Conversation

Tronic
Copy link
Member

@Tronic Tronic commented Mar 16, 2020

As discussed in #1796

@codecov
Copy link

codecov bot commented Mar 26, 2020

Codecov Report

Merging #1807 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1807   +/-   ##
=======================================
  Coverage   92.18%   92.18%           
=======================================
  Files          23       23           
  Lines        2315     2315           
  Branches      425      425           
=======================================
  Hits         2134     2134           
  Misses        141      141           
  Partials       40       40           
Impacted Files Coverage Δ
sanic/app.py 92.25% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a39aff...dd8f376. Read the comment docs.

@yunstanford yunstanford merged commit 7100241 into sanic-org:master Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants