Why doesn't Protocol use app.config to get its settings

[Tronic]

Sanic passes all settings such as REQUEST_MAX_SIZE as arguments via a chain of functions from run_server to Protocol constructor, rather than accessing them via app.config where needed. Is there a purpose to this?

[vltr]

That's a valid question. IMHO it should respect the config given by the developer (from app.config) and a fallback if not available. Repetition of these configs as parameters (even if grabbed from app.config) should not be necessary. But I believe we would need a broad discussion about that to define.

[Tronic]

I suppose this could be removed in a future PR if anyone doesn't have objections to that. The APIs affected by this seem to be internal, as app methods such as create_server do not take these arguments.

[ashleysommer]

@Tronic to answer your question, the reason Protocol doesn't use app.config is simple, the app.config feature didn't exist when the run_server and Protocol constructor code was written in May 2016.

If someone could take it upon themselves to refactor it to use app.config, it would be a good change.

[Tronic]

That should now be sorted out. It's a large and quickly done patch, though, so I would suggest careful review. I did not remove the loop arguments because that would require more work and has potential to break apps that do weird things with multiple loops.