-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug fix for host parameter issue with lists #1776
Conversation
As explained in sanic-org#1772 there is an issue when using a list as an argument for the host parameter in the Blueprint.route() decorator. I've traced the issue back to this line, and the if conditional should ensure that the name attribute isn't accessed when route is None.
Codecov Report
@@ Coverage Diff @@
## master #1776 +/- ##
==========================================
+ Coverage 91.53% 91.63% +0.09%
==========================================
Files 27 27
Lines 3000 3000
Branches 545 545
==========================================
+ Hits 2746 2749 +3
+ Misses 174 172 -2
+ Partials 80 79 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like an okay change. But, it might be nice to have a test with host routing with a string and a list of strings.
Thanks for the PR.
@ahopkins I added some unit tests for using lists with the host parameter. There were already some for testing strings with the host parameter. |
@ahopkins can you resolve your change request if you think that we've met your threshhold? |
Just following up to see if there is anything else I can or need to do in order to get this merged? |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this is incorrect, please respond with an update. Thank you for your contributions. |
#1775 was closed (stale) and this now has tests. Can we resolve this change request and get this merged? |
As explained in #1772 there is an issue when using a list as an argument for the host parameter in the Blueprint.route() decorator. I've traced the issue back to this line, and the if conditional should ensure that the name attribute isn't accessed when route is None.