Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for route decorators #1775

Closed
sjsadowski opened this issue Jan 28, 2020 · 3 comments
Closed

Add tests for route decorators #1775

sjsadowski opened this issue Jan 28, 2020 · 3 comments
Assignees
@sjsadowski
Labels
enhancement stale

Comments

@sjsadowski
Copy link
Contributor

Add tests to prevent reversions on route decorators.
@sjsadowski sjsadowski self-assigned this Jan 28, 2020
@ashleysommer
Copy link
Member

@sjsadowski
I added some basic tests for the multiple-@route decorators, when I submitted my fix:
b565072#diff-4591e684af0cbdb11ee7409ef6f9aa4aR554

Do you know which other decorators don't have proper tests?

@damianj damianj mentioned this issue Jan 31, 2020
Merged
@sjsadowski
Copy link
Contributor Author

@ashleysommer not yet - that's why I assigned it to myself. I may close it, but my biggest concern was not running into another reversion with decorators.

@stale
Copy link

stale bot commented Apr 30, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this is incorrect, please respond with an update. Thank you for your contributions.

@stale stale bot added the stale label Apr 30, 2020
@stale stale bot closed this as completed May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sjsadowski sjsadowski

Labels
enhancement stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ashleysommer @sjsadowski