-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix test dependencies #1463
Fix test dependencies #1463
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1463 +/- ##
=======================================
Coverage 91.38% 91.38%
=======================================
Files 17 17
Lines 1718 1718
Branches 325 325
=======================================
Hits 1570 1570
Misses 123 123
Partials 25 25 Continue to review full report at Codecov.
|
@chenjr0719 Nice catch. |
Thanks for the fix, I've fixed this locally, but didn't push it out. And I'm thinking we should push forward, instead of backpining. |
@chenjr0719 Logically speaking, we only need |
@@ -89,7 +89,7 @@ def open_local(paths, mode="r", encoding="utf8"): | |||
"pytest==3.3.2", | |||
"multidict>=4.0,<5.0", | |||
"gunicorn", | |||
"pytest-cov", | |||
"pytest-cov==2.6.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move pytest
to the latest version instead maybe?
@yunstanford Agreed, let me see is there any error after remove pinned version of @harshanarayana I know, I just make them consistent to make sure this issue will not happen either using |
Notice Travis CI did not pass at #1457, and the reason is current version of
pytest-cov
(2.6.1) usepytest>=3.6
in install _requires(see here). This is conflict withSanic
's test_requires(it usepytest==3.3.2
). Setpytest-cov==2.6.0
in test_requires and tox.ini can fix this issue.BTW, remove
pytest==3.3.2
is also a possible solution. But I don't know why use this version in test_requires, any idea?