Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enforce integer for max-age cookie #1457

Merged
merged 3 commits into from
Jan 13, 2019
Merged

enforce integer for max-age cookie #1457

merged 3 commits into from
Jan 13, 2019

Conversation

r0fls
Copy link
Contributor

@r0fls r0fls commented Jan 3, 2019

Closes: #1452

@codecov
Copy link

codecov bot commented Jan 3, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@2af229e). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1457   +/-   ##
=========================================
  Coverage          ?   91.45%           
=========================================
  Files             ?       17           
  Lines             ?     1732           
  Branches          ?      329           
=========================================
  Hits              ?     1584           
  Misses            ?      123           
  Partials          ?       25
Impacted Files Coverage Δ
sanic/cookies.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2af229e...d418cc9. Read the comment docs.

ahopkins
ahopkins previously requested changes Jan 4, 2019
View reviewed changes
Copy link
Member

@ahopkins ahopkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also add "30.0" to the tests.

harshanarayana
harshanarayana requested changes Jan 4, 2019
View reviewed changes
sanic/cookies.py Show resolved Hide resolved
tests/test_cookies.py Outdated Show resolved Hide resolved
@chenjr0719 chenjr0719 mentioned this pull request Jan 8, 2019
Closed
@yunstanford
Copy link
Member

hey, can you fix the linting issue ?

@r0fls
Copy link
Contributor Author

r0fls commented Jan 11, 2019

Hmm, seems there are some unrelated issues with the Travis build maybe, e.g.: pluggy.PluginValidationError: Plugin 'pytest_cov' could not be loaded: (pytest 3.3.2 (/home/travis/build/huge-success/sanic/.tox/py35/lib/python3.5/site-packages), Requirement.parse('pytest>=3.6'))!

@yunstanford
Copy link
Member

@r0fls the issue has been fixed in master branch. you can merge/rebase from master. it should be fixed.

@yunstanford yunstanford merged commit 99f34c9 into master Jan 13, 2019
@ahopkins ahopkins deleted the max-age-integer branch March 25, 2019 14:42
@Tronic Tronic mentioned this pull request Apr 3, 2020
Closed
@myusko myusko mentioned this pull request Aug 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahopkins ahopkins ahopkins left review comments

@harshanarayana harshanarayana harshanarayana requested changes

@yunstanford yunstanford yunstanford approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@r0fls @yunstanford @ahopkins @harshanarayana