chardet version bump

[Alessandro-Barbieri]

Do you really need that old chardet version?

[ahopkins]

What version of sanic are you using?

A couple things on that:

1. chardet is an upstream dependency from httpx, we do not control that
2. It looks like httpx is requesting the latest version [according to pypi[(https://pypi.org/project/chardet/)
3. We are in the process of removing httpx as a dependency since it is really only used in testing

[ashleysommer]

@Alessandro-Barbieri
Is this question resolved for you?

[Alessandro-Barbieri]

Can you remove dependency not strictly required, why do you need the deps dependencies? This will make manual packaging more easy

[ahopkins]

Did you read the links? If yes, I'm not sure I understand the question.

[Alessandro-Barbieri]

@Alessandro-Barbieri
Is this question resolved for you?

Now that I know, I'll just remove the chardet dependency from the package. I think it's better to leave this issue open until it's really removed or it's version bumped.

[Alessandro-Barbieri]

I was suggesting in removing all the requirements that are dependency of the dependencies since you'll get them installed anyway with a decent package manager

[ahopkins]

It is not. Where are you looking?

requirements = [
    "httptools>=0.0.10",
    uvloop,
    ujson,
    "aiofiles>=0.3.0",
    "websockets>=7.0,<9.0",
    "multidict>=4.0,<5.0",
    "httpx==0.11.1",
]

From setup.py

[Alessandro-Barbieri]

tox.ini https://github.com/huge-success/sanic/blob/bedf68a9b2025618a94cb8044f495a0abd87a134/tox.ini#L17 Il Sab 13 Giu 2020, 20:47 Adam Hopkins <[email protected]> ha scritto:

…

It is not. Where are you looking? requirements = [ "httptools>=0.0.10", uvloop, ujson, "aiofiles>=0.3.0", "websockets>=7.0,<9.0", "multidict>=4.0,<5.0", "httpx==0.11.1", ] From setup.py — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1858 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACRRZSYXZUIYCPKUSDH26ITRWPCT7ANCNFSM4NDFXKSQ> .

[Tronic]

Fix just merged upstream in httpx, they no longer use chardet.