Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix uvloop 1912 #2025

Merged
merged 6 commits into from
Feb 16, 2021
Merged

Fix uvloop 1912 #2025

merged 6 commits into from
Feb 16, 2021

Conversation

ahopkins
Copy link
Member

Related to #2024

@ahopkins ahopkins added the LTS label Feb 15, 2021
@codecov
Copy link

codecov bot commented Feb 15, 2021

Codecov Report

Merging #2025 (23a0308) into 19.12LTS (a7d563d) will increase coverage by 0.10%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           19.12LTS    #2025      +/-   ##
============================================
+ Coverage     89.84%   89.94%   +0.10%     
============================================
  Files            25       25              
  Lines          2945     2945              
  Branches        546      546              
============================================
+ Hits           2646     2649       +3     
+ Misses          224      222       -2     
+ Partials         75       74       -1     
Impacted Files Coverage Δ
sanic/server.py 75.28% <0.00%> (+0.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7d563d...23a0308. Read the comment docs.

@ahopkins ahopkins mentioned this pull request Feb 15, 2021
@ashleysommer
Copy link
Member

ashleysommer commented Feb 15, 2021

Strange dependency issue happening in this branch now.
Something is causing MultiDict==5.1.0 to be installed, but this version of Sanic is pinned MultiDict==5.0.0 resulting in a PIP install error.

@ashleysommer
Copy link
Member

ashleysommer commented Feb 15, 2021

Another oddity I found while trying to debug that conflict above:

ERROR: Cannot install chardet<=2.3.0 and httpcore==0.3.0 because these package versions have conflicting dependencies.

The conflict is caused by:
    The user requested chardet<=2.3.0
    httpcore 0.3.0 depends on chardet==3.*

Looks like this is related to https://github.com/sanic-org/sanic/issues/1858|
For some reason we have chardet locked to a very old version in our tox.ini, I've seen this done in the past for old requests or old pip compatibility, it can probably be removed now.

@ashleysommer
Copy link
Member

Created #2027 to fix the TOX requirement install issues.
Merge #2027 then resync to #2025 and re-run the tests.

@ahopkins ahopkins merged commit 4c360f4 into 19.12LTS Feb 16, 2021
@ahopkins ahopkins deleted the fix-uvloop-1912 branch February 16, 2021 06:49
@ahopkins
Copy link
Member Author

All good 😎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants