Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nick/sum tensor #282

Merged
merged 11 commits into from
Nov 3, 2023
Merged

Nick/sum tensor #282

merged 11 commits into from
Nov 3, 2023

Conversation

ntjohnson1
Copy link
Collaborator

@ntjohnson1 ntjohnson1 commented Oct 16, 2023

This PR comes to you courtesy of my delta flights today.

Resolves #73 and I think handles #272 as well. You linked your sptensor branch but I didn't see it already resolved over there. Up to you on order of operations merging things. The norm placeholder is kind of weird so we should probably make an issue to resolve that.

SUMTENSOR Methods:

  • disp - __repr__
  • display - __str__
  • double - double
  • full - full
  • innerprod - innerprod
  • isscalar - Not needed in pyttb
  • mttkrp - mttkrp
  • ndims - ndims
  • norm - norm
  • plus - __add__, __radd__
  • size - shape
  • subsref - We just allow direct access to parts if we wanted to restrict direct editing could make it a getter instead
  • sumtensor - __init__ and copy
  • ttv - ttv
  • uminus - __neg__
  • uplus - __pos__

📚 Documentation preview 📚: https://pyttb--282.org.readthedocs.build/en/282/

@ntjohnson1 ntjohnson1 marked this pull request as ready for review October 16, 2023 00:32
@ntjohnson1 ntjohnson1 requested a review from dmdunla October 16, 2023 00:32
@dmdunla dmdunla merged commit e2a7661 into sandialabs:main Nov 3, 2023
@ntjohnson1 ntjohnson1 deleted the nick/sum_tensor branch November 3, 2023 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement sumtensor class
2 participants