Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ttv return value type consistency #272

Closed
dmdunla opened this issue Sep 28, 2023 · 0 comments · Fixed by #219
Closed

ttv return value type consistency #272

dmdunla opened this issue Sep 28, 2023 · 0 comments · Fixed by #219
Labels
bug Something isn't working documentation Improvements or additions to documentation
Milestone

Comments

@dmdunla
Copy link
Collaborator

dmdunla commented Sep 28, 2023

Currently, we have the following output types for ttv in the various data classes:

- ktensor.ttv -> Union[float, ktensor]
- tensor.ttv -> tensor
- sptensor.ttv -> Union[sptensor, ttb.tensor]
- ttensor.ttv -> Union[float, ttensor]

All should support float and I think they do. But this should be verified and the type hints should be updated to include float across all.

@dmdunla dmdunla added bug Something isn't working documentation Improvements or additions to documentation labels Sep 28, 2023
@dmdunla dmdunla added this to the v2.0 milestone Sep 28, 2023
@dmdunla dmdunla linked a pull request Sep 29, 2023 that will close this issue
@ntjohnson1 ntjohnson1 mentioned this issue Oct 16, 2023
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant