Adding hydrodynamics and mooring sections to OWENS Dev Guide #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kevmoor This is ready for your review (doesn't look like I can assign you as a reviewer in the PR for some reason). |
kevmoor
approved these changes
Oct 15, 2024
|
Sounds good, I will create a new issue for the zcm problem and then merge this. |
|
Created #83 for the one outstanding issue, merging this now. Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides "under the hood" details on the internal solve procedure and OWENS structures for floating capabilities, in the event that future developers modify any of this. There is one TODO in this that will point to a floating capabilities literate notebook, which I will get to shortly. The notebook will include some top-level details about the syntax for the platform mesh that will be relevant to all users.
Closes #79