Resources need to include the depositor to be included in search results #4787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This limiting part of the query that provides the list of works for Dashboard -> Works is…
```
"fq"=>["{!terms f=has_model_ssim}GenericWork,NamespacedWorks::NestedWork,Monograph", "_query_:\"{!raw f=depositor_ssim}[email protected]\""]
```
So without the depositor in the solr doc, Monographs, which are Valkyrie::Resources, were never returned in the search results. Adding in the depositor, they are now included.
Remaining Work:
* The thumbnail image is not displayed in the list, but is in the show page for the Monograph.
elrayle
force-pushed
the
fix/4786_dashboard_works_resources
branch
from
1990357
to
274408d
Compare
escowles
approved these changes
Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #4786
Description
After adding a Monograph, which is a Valkyrie::Resource, through the UI, it was not included in the list of works on Dashboard -> Works. This was caused by the indexer for Valkyrie based works not including the depositor in the solr doc.
This limiting part of the query that provides the list of works for Dashboard -> Works is…
So without the depositor in the solr doc, Monographs, which are were never returned in the search results. Adding in the depositor, they are now included.
Remaining Work
@samvera/hyrax-code-reviewers