-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hyrax::Works do not show thumbnail in Dashboard -> Works #4788
Comments
related to #4191? |
PrerequisiteIssue #5480 should be resolved before exploring this issue. There are several issues with files on a work show page. When they are resolved, it is possible the viewer will work as expected. Also related work...Issue #5480 - image file in Items section of work show page is a link instead of a title |
❌. @jlhardes This ticket did not pass QA. I created a Monograph, and added an image file, and was unable to see the image as a thumbnail of the monograph under the "Works" list, as shown below: I was also unable to get the thumbnails to display correctly on the Monograph's show page, so it could potentially be an issue with my account specifically. I get the following error: |
On nurax-pg, there is no monograph work type. I did test using the image work type, but the image does not load in the image viewer. The thumbnail on the works page does not load. On nurax-dev, a monograph work type exists, but the image viewer does not load. The thumbnail on the works page does not load |
For a Monograph work on nurax-dev, it looks like there is a generic thumbnail that shows in the file list. Is that an improvement over what was occurring in the original report? I am not clear on that but it seems like there is a thumbnail now where there wasn't one before. When an image file is in the file list on a Monograph work on nurax-dev, a thumbnail of that image file is what is expected and the generic thumbnail image is what is showing. Is that a problem? I am reopening this issue to get some more info on expected behavior. It is possible what we have in place on nurax-dev is the expected fix for this issue but I am not completely clear since the steps to reproduce involve uploading an image file to a Monograph work. |
Per discussion in Hyrax Maintenance Working Group standup (2/22/2023), we do expect thumbnails to display for Monograph works. Currently, they do not display on nurax-dev for 4.0.0.beta2 |
Verified this is still present on Hyrax 5.0.0 on https://dev.nurax.samvera.org/. Created a Monograph work and the attached image has not processed beyond the fileset identifier in the Items list and only the generic thumbnail shows for the work in the Works list on the Dashboard. |
Prerequisite to Resolving this Issue
Need PR #4787 (Resources need to include the depositor to be included in search results) to be merged first. Without this PR, the monograph won't be in the list of works on Dashboard -> Works.
Descriptive summary
Any work that is_a Hyrax::Work (e.g. Monograph), which is a Valkyrie::Resource, does not include its thumbnail in the list of works in Dashboard -> Works.
Rationale
All works with thumbnails should show the thumbnail in the list of works on Dashboard -> Works -> Your Works (tab).
Expected behavior
Monographs that have thumbnails should have the thumbnail included in the list of works in Dashboard -> Works -> Your Works (tab).
gw03-15-01 prime
is_aGenericWork
is_aActiveFedora::Base
and should show a thumbnail.m03-15-01
is_aMonograph
is_aValkyrie::Resource
and should show a thumbnail.Actual behavior
Monographs that have thumbnails show the title but not the thumbnail in the list of works in Dashboard -> Works -> Your Works (tab).
gw03-15-01 prime
is_aGenericWork
is_aActiveFedora::Base
and shows a thumbnail.m03-15-01
is_aMonograph
is_a `Valkyrie::Resource`` and does NOT show a thumbnail.Steps to reproduce the behavior
The new Monograph is listed, but the thumbnail is not displayed.
Related Issues
Issue #4795 - Hyrax::Works do not show Date Added in Dashboard -> Works
Issue #4794 - Hyrax::Works do not index file sets
Issue #4487 - Solr docs generated by ActiveFedora and Hyrax::ValkyrieWorkIndexer are not compatible
The text was updated successfully, but these errors were encountered: