Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyrax::Works do not show thumbnail in Dashboard -> Works #4788

Open
elrayle opened this issue Mar 15, 2021 · 7 comments · Fixed by #5524
Open

Hyrax::Works do not show thumbnail in Dashboard -> Works #4788

elrayle opened this issue Mar 15, 2021 · 7 comments · Fixed by #5524

Comments

@elrayle
Copy link
Contributor

elrayle commented Mar 15, 2021

Prerequisite to Resolving this Issue

Need PR #4787 (Resources need to include the depositor to be included in search results) to be merged first. Without this PR, the monograph won't be in the list of works on Dashboard -> Works.

Descriptive summary

Any work that is_a Hyrax::Work (e.g. Monograph), which is a Valkyrie::Resource, does not include its thumbnail in the list of works in Dashboard -> Works.

Rationale

All works with thumbnails should show the thumbnail in the list of works on Dashboard -> Works -> Your Works (tab).

Expected behavior

Monographs that have thumbnails should have the thumbnail included in the list of works in Dashboard -> Works -> Your Works (tab).

gw03-15-01 prime is_a GenericWork is_a ActiveFedora::Base and should show a thumbnail.
m03-15-01 is_a Monograph is_a Valkyrie::Resource and should show a thumbnail.

Actual behavior

Monographs that have thumbnails show the title but not the thumbnail in the list of works in Dashboard -> Works -> Your Works (tab).

gw03-15-01 prime is_a GenericWork is_a ActiveFedora::Base and shows a thumbnail.
m03-15-01 is_a Monograph is_a `Valkyrie::Resource`` and does NOT show a thumbnail.

image

Steps to reproduce the behavior

  1. Login
  2. Dashboard -> Works -> Add new work -> select Monograph as the work type
  3. Fill in required fields
  4. Add an image file
  5. Save (forwards to the show page for the Monograph work)
  6. Click Works in the breadcrumb to return to Dashboard -> Works

The new Monograph is listed, but the thumbnail is not displayed.

Related Issues

Issue #4795 - Hyrax::Works do not show Date Added in Dashboard -> Works
Issue #4794 - Hyrax::Works do not index file sets
Issue #4487 - Solr docs generated by ActiveFedora and Hyrax::ValkyrieWorkIndexer are not compatible

@hackartisan
Copy link
Contributor

related to #4191?

@elrayle
Copy link
Contributor Author

elrayle commented Mar 1, 2022

Prerequisite

Issue #5480 should be resolved before exploring this issue. There are several issues with files on a work show page. When they are resolved, it is possible the viewer will work as expected.

Also related work...

Issue #5480 - image file in Items section of work show page is a link instead of a title
Issue #5474 - failure to show the file in the universal viewer on work show page

@abelemlih
Copy link
Contributor

❌. @jlhardes This ticket did not pass QA. I created a Monograph, and added an image file, and was unable to see the image as a thumbnail of the monograph under the "Works" list, as shown below:

Screen Shot 2022-03-23 at 12 40 10 PM

I was also unable to get the thumbnails to display correctly on the Monograph's show page, so it could potentially be an issue with my account specifically. I get the following error:

Screen Shot 2022-03-23 at 12 46 24 PM

@abelemlih abelemlih assigned jlhardes and unassigned abelemlih Mar 23, 2022
@rjkati
Copy link

rjkati commented Apr 18, 2022

On nurax-pg, there is no monograph work type. I did test using the image work type, but the image does not load in the image viewer. The thumbnail on the works page does not load.
Example: https://nurax-pg.curationexperts.com/concern/images/a87cb0a8-fc8b-4830-9b53-b084d799fc93?locale=en
nurax-pg_imageviewer
nurax-pg_thumbnails

On nurax-dev, a monograph work type exists, but the image viewer does not load. The thumbnail on the works page does not load
Example: https://nurax-dev.curationexperts.com/concern/monographs/c534fp131?locale=en
nurax-dev_imageviewer

nurax-dev_workpage

@jlhardes
Copy link
Contributor

For a Monograph work on nurax-dev, it looks like there is a generic thumbnail that shows in the file list. Is that an improvement over what was occurring in the original report? I am not clear on that but it seems like there is a thumbnail now where there wasn't one before.

When an image file is in the file list on a Monograph work on nurax-dev, a thumbnail of that image file is what is expected and the generic thumbnail image is what is showing. Is that a problem?

I am reopening this issue to get some more info on expected behavior. It is possible what we have in place on nurax-dev is the expected fix for this issue but I am not completely clear since the steps to reproduce involve uploading an image file to a Monograph work.

@rjkati
Copy link

rjkati commented Feb 22, 2023

Per discussion in Hyrax Maintenance Working Group standup (2/22/2023), we do expect thumbnails to display for Monograph works. Currently, they do not display on nurax-dev for 4.0.0.beta2

@jlhardes
Copy link
Contributor

Verified this is still present on Hyrax 5.0.0 on https://dev.nurax.samvera.org/. Created a Monograph work and the attached image has not processed beyond the fileset identifier in the Items list and only the generic thumbnail shows for the work in the Works list on the Dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants