Add thumbnail and representative ids and paths to valkyrie solr indexers #5524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Resource This happens when creating a Monograph without Valkyrie indexing enabled. Fixes monograph deposit feature spec.
elrayle
reviewed
Mar 15, 2022
There was a problem hiding this comment.
Basically looks good. @tpendragon do you want to review before this is merged?
| def to_solr | ||
| { | ||
| "id": resource.id.to_s, | ||
| "date_uploaded_dtsi": resource.created_at, | ||
| "date_modified_dtsi": resource.updated_at, | ||
| "has_model_ssim": resource.internal_resource | ||
| } | ||
| }.with_indifferent_access |
There was a problem hiding this comment.
This will make life easier.
| @@ -0,0 +1,31 @@ | |||
| # frozen_string_literal: true | |||
| module Hyrax | |||
| module ThumbnailIndexer | |||
There was a problem hiding this comment.
Nice abstraction. This will help with consistency and keeping the code DRY.
| # Which FileSet file to use for mime type resolution | ||
| # @ see Hyrax::FileSetTypeService | ||
| attr_writer :characterization_proxy | ||
| def characterization_proxy |
There was a problem hiding this comment.
good to have this as a configuration
tpendragon
approved these changes
Mar 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4788 (shows the default thumbnail until derivative creation is done)
Adds indexing for thumbnails and representative objects to valkyrie solr index.
Other changes:
services/indexes_thumbnails.rbtoindexers/hyrax/thumbnail_indexer.rb