Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix for localizedAppName nil #132

Merged
merged 1 commit into from
Oct 7, 2022
Merged

bugfix for localizedAppName nil #132

merged 1 commit into from
Oct 7, 2022

Conversation

gecsbernat
Copy link
Contributor

@gecsbernat gecsbernat commented Oct 7, 2022 •
edited
Loading

Fix for: #131

@gecsbernat gecsbernat marked this pull request as draft October 7, 2022 10:55
@gecsbernat gecsbernat marked this pull request as ready for review October 7, 2022 10:55
@gecsbernat
Copy link
Contributor Author

Hello @sampart !

With this fix: #127 a new bug came in!

Not every app has a localized appName!
Please review this PR and make a new release with the fix!

Thank you! :)

@sampart sampart merged commit 98cf1b7 into sampart:master Oct 7, 2022
@sampart
Copy link
Owner

sampart commented Oct 7, 2022

Thanks @gecsbernat! Here's a release: https://github.com/sampart/cordova-plugin-app-version/releases/tag/0.1.15

@sampart sampart mentioned this pull request Oct 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gecsbernat @sampart