iOS: getAppName to return localized value (like Android) #127
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #126
This plugin's iOS
#getAppName
current implementation is usinginfoDictionary
, and should switch tolocalizedInfoDictionary
to get localized value instead.Same situation described in https://stackoverflow.com/questions/9155985/how-to-get-localized-cfbundledisplayname,
with 2 solutions both working great:
[[[NSBundle mainBundle] localizedInfoDictionary] objectForKey:@"CFBundleDisplayName"]
⇒ gone for this one, as all other methods follow this same structure
[[NSBundle mainBundle] objectForInfoDictionaryKey:@"CFBundleDisplayName"]
(see objectForInfoDictionaryKey)