Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS: getAppName to return localized value (like Android) #127

Merged
merged 1 commit into from
Feb 24, 2022

Conversation

ath0mas
Copy link
Contributor

@ath0mas ath0mas commented Feb 16, 2022

Fix #126

This plugin's iOS #getAppName current implementation is using infoDictionary, and should switch to localizedInfoDictionary to get localized value instead.

Same situation described in https://stackoverflow.com/questions/9155985/how-to-get-localized-cfbundledisplayname,
with 2 solutions both working great:

  • [[[NSBundle mainBundle] localizedInfoDictionary] objectForKey:@"CFBundleDisplayName"]
    ⇒ gone for this one, as all other methods follow this same structure
  • [[NSBundle mainBundle] objectForInfoDictionaryKey:@"CFBundleDisplayName"]
    (see objectForInfoDictionaryKey)

@sampart sampart merged commit fc37d5d into sampart:master Feb 24, 2022
@sampart
Copy link
Owner

sampart commented Feb 24, 2022

Thanks for contributing! Let me know if you need a new release making to include this.

@ath0mas ath0mas deleted the ios-app-name-localized branch February 24, 2022 19:54
@ath0mas
Copy link
Contributor Author

ath0mas commented Feb 24, 2022

Thank you, publishing a new release would be nice yes :).

@sampart
Copy link
Owner

sampart commented Mar 1, 2022

@ath0mas
Copy link
Contributor Author

ath0mas commented Mar 3, 2022

Thanks, please can you publish it on Npmjs too?

@sampart
Copy link
Owner

sampart commented Mar 9, 2022

Sure thing. I've done that now.

The npm web UI is still showing the old version for me at present, but npm view cordova-plugin-app-version shows that 0.1.13 really is up there! Thanks

@sampart
Copy link
Owner

sampart commented Mar 9, 2022

I had to recreate the GitHub release and change the tag as well, FYI. Hope that's not a problem.

@ath0mas
Copy link
Contributor Author

ath0mas commented Mar 9, 2022

Great, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iOS: getAppName should be localized like for Android
2 participants