Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows: force a version of k3s that should fix our ci issues #99

Merged
merged 1 commit into from
Sep 24, 2021
Merged

workflows: force a version of k3s that should fix our ci issues #99

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ jobs:
- name: Create k3d registry
run: k3d registry create "${REG_BASE}" --port "${REG_PORT}"
- name: Create k3d cluster
run: k3d cluster create --wait --registry-use "${REGISTRY}"
run: k3d cluster create --wait --image docker.io/rancher/k3s:v1.21.5-k3s1 --registry-use "${REGISTRY}"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of hardcoding to one particular patch version, would it make more sense to lock on to a Minor version?

Something like

IMAGE_TAG=$(curl --silent "https://update.k3s.io/v1-release/channels/v1.21" | egrep -o '/v[^ ]+"' | sed -E 's/\/|\"//g' | sed -E 's/\+/\-/')
k3d cluster create --wait --image docker.io/rancher/k3s:${IMAGE_TAG} --registry-use "${REGISTRY}"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, let's follow up with something like that in a follow-up pr.

- name: Wait for cluster ready
run: |
while ! kubectl get serviceaccount default >/dev/null; do sleep 1; done
Expand Down