workflows: force a version of k3s that should fix our ci issues #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See: k3s-io/k3s#3704 Figuring out what to actually put on the --image option was far harder than it seems it should have been. :-\ Signed-off-by: John Mulligan <[email protected]>
raghavendra-talur
approved these changes
Sep 23, 2021
| @@ -113,7 +113,7 @@ jobs: | |||
| - name: Create k3d registry | |||
| run: k3d registry create "${REG_BASE}" --port "${REG_PORT}" | |||
| - name: Create k3d cluster | |||
| run: k3d cluster create --wait --registry-use "${REGISTRY}" | |||
| run: k3d cluster create --wait --image docker.io/rancher/k3s:v1.21.5-k3s1 --registry-use "${REGISTRY}" | |||
There was a problem hiding this comment.
Instead of hardcoding to one particular patch version, would it make more sense to lock on to a Minor version?
Something like
IMAGE_TAG=$(curl --silent "https://update.k3s.io/v1-release/channels/v1.21" | egrep -o '/v[^ ]+"' | sed -E 's/\/|\"//g' | sed -E 's/\+/\-/')
k3d cluster create --wait --image docker.io/rancher/k3s:${IMAGE_TAG} --registry-use "${REGISTRY}"
There was a problem hiding this comment.
Sure, let's follow up with something like that in a follow-up pr.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: k3s-io/k3s#3704
Figuring out what to actually put on the --image option was far harder
than it seems it should have been. :-\
Signed-off-by: John Mulligan [email protected]