Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pool running improvements #55202

Merged
merged 8 commits into from
Dec 23, 2019
Merged

pool running improvements #55202

merged 8 commits into from
Dec 23, 2019

Commits on Dec 23, 2019

  1. Fix virt._gen_pool_xml when all source parameters are None 

    When all the source_* parameters of _gen_pool_xml are None, no <source>
element should be generated. Instead we had the following:

    <source><path dir="None"/></source>

Rather than filling a source structure with empty members, directly pass
a None for the source as expected by the jinja template.
    @cbosdo
    cbosdo committed Dec 23, 2019
    Configuration menu
    Copy the full SHA
    8a0d5c0 View commit details
    Browse the repository at this point in the history

  2. Add virt.pool_update function 

    Add a function that allows changing a virtual storage pool. By using the
test=True parameter, this function can be used to check if a change
would be done.
    @cbosdo
    cbosdo committed Dec 23, 2019
    Configuration menu
    Copy the full SHA
    29f3f28 View commit details
    Browse the repository at this point in the history

  3. virt.pool_running state improvements 

    With this commit the virt.pool_running state is capable to update an
existing pool before ensuring it is running.

This also adds support for the test parameter.
    @cbosdo
    cbosdo committed Dec 23, 2019
    Configuration menu
    Copy the full SHA
    1de2ece View commit details
    Browse the repository at this point in the history

  4. Fix virt.pool_define documentation 

    virt.pool_define example are mentioning a uuid property while this one
should be named value. The code was right, but not the doc.
    @cbosdo
    cbosdo committed Dec 23, 2019
    Configuration menu
    Copy the full SHA
    2d3e732 View commit details
    Browse the repository at this point in the history

  5. Add source_initiator parameter in virt.pool_define 

    In order to define iscsi-direct virtual storage pools, the use needs to
be able to provide the initiator IQN. Add a parameter for it in:
  * virt.pool_define module function
  * virt.pool_update module function
  * virt.pool_running state
    @cbosdo
    cbosdo committed Dec 23, 2019
    Configuration menu
    Copy the full SHA
    324a201 View commit details
    Browse the repository at this point in the history

  6. virt pool secret have no type attribute 

    According to libvirt schemas and doc only the volume secrets have a
type.
    @cbosdo
    cbosdo committed Dec 23, 2019
    Configuration menu
    Copy the full SHA
    22dec4b View commit details
    Browse the repository at this point in the history

  7. virt: create and update pool secret's password for the user 

    Libvirt stores RBD and iSCSI passwords in secrets. Add a password field
in the source_auth parameter of virt.pool_define and virt.pool_update to
set the password value rather than reuse an already defined libvirt
secret.
    @cbosdo
    cbosdo committed Dec 23, 2019
    Configuration menu
    Copy the full SHA
    a1a104b View commit details
    Browse the repository at this point in the history

  8. virt.pool_define: remove potential leading / in CIFS source path 

    libvirt needs the CIFS source path not to start with a /. Let's remove
them since this could be a common user mistake.
    @cbosdo
    cbosdo committed Dec 23, 2019
    Configuration menu
    Copy the full SHA
    24f593a View commit details
    Browse the repository at this point in the history