pool running improvements #55202
Merged
pool running improvements #55202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
cbosdo
force-pushed
the
master-pool-running-improvements
branch
from
daa649c
to
14b3ff4
Compare
cbosdo
force-pushed
the
master-pool-running-improvements
branch
from
14b3ff4
to
c1d6831
Compare
|
Based on master + PR #54196 |
cbosdo
force-pushed
the
master-pool-running-improvements
branch
2 times, most recently
from
f063b84
to
5046b48
Compare
cbosdo
force-pushed
the
master-pool-running-improvements
branch
3 times, most recently
from
79f18f1
to
e29d35e
Compare
When all the source_* parameters of _gen_pool_xml are None, no <source>
element should be generated. Instead we had the following:
<source><path dir="None"/></source>
Rather than filling a source structure with empty members, directly pass
a None for the source as expected by the jinja template.
Add a function that allows changing a virtual storage pool. By using the test=True parameter, this function can be used to check if a change would be done.
With this commit the virt.pool_running state is capable to update an existing pool before ensuring it is running. This also adds support for the test parameter.
virt.pool_define example are mentioning a uuid property while this one should be named value. The code was right, but not the doc.
In order to define iscsi-direct virtual storage pools, the use needs to be able to provide the initiator IQN. Add a parameter for it in: * virt.pool_define module function * virt.pool_update module function * virt.pool_running state
According to libvirt schemas and doc only the volume secrets have a type.
Libvirt stores RBD and iSCSI passwords in secrets. Add a password field in the source_auth parameter of virt.pool_define and virt.pool_update to set the password value rather than reuse an already defined libvirt secret.
libvirt needs the CIFS source path not to start with a /. Let's remove them since this could be a common user mistake.
cbosdo
force-pushed
the
master-pool-running-improvements
branch
from
e29d35e
to
24f593a
Compare
dwoz
approved these changes
Dec 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Enhances the
virt.pool_runningstate to allow editing the pool and handle the test parameter.What issues does this PR fix or reference?
Previous Behavior
virt.pool_runningwould only be reporting on a running or starting an existing pool.New Behavior
virt.pool_runningnow updates an existing pool if needed, thus restarting the pool if changed.It also handles the
testparameter.Tests written?
Yes
Commits signed with GPG?
Yes